Skip to content
This repository has been archived by the owner on Nov 18, 2024. It is now read-only.

Try: Update underline thickness #615

Closed
wants to merge 1 commit into from
Closed

Try: Update underline thickness #615

wants to merge 1 commit into from

Conversation

carolinan
Copy link
Contributor

@carolinan carolinan commented Oct 22, 2024 •
edited
Loading

Description
An attempt to solve #612
I can clearly see the difference in the underline thickness in the screenshots in the issue, but I can't actually see it in the browser. I tried Chrome and Firefox on Windows. So I will need help determining if this change solves the problem.

Testing Instructions
View the default single post template in the Site Editor.
It needs to be the Site Editor, because in this editor, the category in the post terms is not a link.
Below the featured image, observer the thickness of the underlines on the post author name and the category.
The thickness should be the same, 1px.

@github-actions GitHub Actions
Copy link

Preview changes

You can preview these changes by following the link below:

I will update this comment with the latest preview links as you push more changes to this PR.

Note

The preview sites are created using WordPress Playground. You can add content, edit settings, and test the themes as you would on a real site, but please note that changes are not saved between sessions.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 22, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: carolinan <[email protected]>
Co-authored-by: richtabor <[email protected]>
Co-authored-by: juanfra <[email protected]>
Co-authored-by: beafialho <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@carolinan carolinan requested a review from beafialho October 22, 2024 10:49
@carolinan carolinan added the [Type] Enhancement A suggestion for improvement. label Oct 22, 2024
@juanfra juanfra mentioned this pull request Oct 22, 2024
Closed
@juanfra juanfra linked an issue Oct 22, 2024 that may be closed by this pull request
Link underline thickness inconsistency across post terms and author #612
Closed
@richtabor
Copy link
Member

richtabor commented Oct 22, 2024 •
edited
Loading

I don't think we should be applying such specific styling. Instead we should avoid styling regular text as links.

If a user does apply an underline on a linked text, then having it larger (currently in trunk) is fine, as it helps you identify the link.

@carolinan carolinan closed this Oct 22, 2024
@carolinan
Copy link
Contributor Author

Hopefully the bug with the missing element on the category in the Site Editor can be solved soon, I saw a similar PR in the Gutenberg repository earlier today.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@beafialho beafialho Awaiting requested review from beafialho

Assignees
No one assigned
Labels
[Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Link underline thickness inconsistency across post terms and author
2 participants
@carolinan @richtabor